Question

I have to read the below SQL statement from one properties.

update  scoreconfig  set scorestatus=0 where scoreversion=props.getProperty("scoreversion");

And value for score version I’ve to take it from other properties file.

But, when I prepare a statement in java function as below:

final String query = strLine;
PreparedStatement ps=con.prepareStatement(query);

where query has

update  scoreconfig  set scorestatus=0 where scoreversion=props.getProperty("scoreversion");

But I get

Error: ORA-00911: invalid character

…when I do ps.execute();

Answer 1

I assume props is a Properties instance or similar. If so, the props.getProperty("scoreversion") part is meant to happen at the Java layer, not in the database. Instead:

String sql = "update scoreconfig set scorestatus=0 where scoreversion=?";
PreparedStatement ps = con.prepareStatement(sql);
// If scoreversion is a String:
ps.setString(1, props.getProperty("scoreversion"));
ResultSet rs = ps.executeQuery();

…or if scoreversion is an int, use this instead of the setString line:

// It scoreversion is an int:
ps.setInt(1, Integer.parseInt(props.getProperty("scoreversion")));

…etc., convert as appropriate.

Basically, when you use prepareStatement, you use ? where parameters should go, and then you use setXyz on the PreparedStatement instance to set those parameters. (Oddly, they start with 1, not 0.) Note that even when the parameter is a String, you don’t put quotes around it in the SQL you pass into prepareStatement; that’s handled for you (along with properly escaping that string to prevent SQL injection, so PreparedStatement and setXyz are your friends, you’ll get to know them well).