Question

I have written the Database class & trying to insert the values in the database but i am getting Exception like this android.database.sqlite.SQLiteException: near “15”: syntax error: , while compiling:

insert into tbl_setmessage (Title,Message,DateFrom,StartTime,ExpiryDate,ExpiryTime)        values 
('Swapnil','hii','12-3-2012 '15:53'14-3-2012 '15:54')

what is the problem

My Databse class is

public class DataBaseCreator {
private static final String DATABASE_NAME = "SetMessage.db";
private static final int DATABASE_VERSION = 1;
private Context context;
private SQLiteDatabase db;
private SQLiteStatement insertStmt;

public DataBaseCreator(Context context) {
    this.context = context;
    OpenHelper openHelper = new OpenHelper(this.context);
    this.db = openHelper.getWritableDatabase();
}


public long insert(String TABLE_NAME, String TABLE_FIELDS, String TABLE_VALUES) {
    String INSERT = "insert into " 
            + TABLE_NAME + "("+ TABLE_FIELDS +") values ("+TABLE_VALUES+")";
    this.insertStmt = this.db.compileStatement(INSERT);
    return this.insertStmt.executeInsert();
}
public void closeDb() {
    this.db.close();
}  

private static class OpenHelper extends SQLiteOpenHelper {

    OpenHelper(Context context) {
        super(context, DATABASE_NAME, null, DATABASE_VERSION);
    }

    @Override
    public void onCreate(SQLiteDatabase db) {
        db.execSQL("CREATE TABLE Set_message (Tittle VARCHAR(30) NOT NULL," +
     "Message VARCHAR(30) NOT NULL,"+
        "Date_from DATETIME NOT NULL,"+
         "Start_Time DATETIME NOT NULL,"+
        "Expiry_Date DATETIME NOT NULL,"+
         "Expiry_Time DATETIME NOT NULL)");

    }

    @Override
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
        db.execSQL("DROP DATABASE IF EXISTS " + DATABASE_NAME);
        onCreate(db);
    }

}

public void open() {
    // TODO Auto-generated method stub

}

}

and main class is

btn_SetMessage.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View v) {
            baseCreator.insert("tbl_setmessage ","Title,Message,DateFrom,StartTime,ExpiryDate,ExpiryTime","'"+tv1.getText()+"','"
                    +tv2.getText()+"','"+StartDate.getText()+"'"+StartTime.getText()+"'"+ExpiryDate.getText()+"'"+ExpiryTime.getText()+"'");
            Intent i=new Intent(SetMessage.this,SelectLocation.class);
            startActivity(i);
        }
    });

Answer 1

Try:

btn_SetMessage.setOnClickListener(new OnClickListener() {

    @Override
    public void onClick(View v) {
        baseCreator.insert("tbl_setmessage ","Title,Message,DateFrom,StartTime,ExpiryDate,ExpiryTime","'"+tv1.getText()+"','"
                +tv2.getText()+"','"+StartDate.getText()+"','"+StartTime.getText()+"','"+ExpiryDate.getText()+"','"+ExpiryTime.getText()+"'");
        Intent i=new Intent(SetMessage.this,SelectLocation.class);
        startActivity(i);
    }
});

You lost some ” ‘,’ “