Question

I need parse my XML file and save parsed XML to SQL database. My XML contents several tags <goods_item>. If it contains only one tag, it works fine. But else there are mistakes.

SQL query:

declare @insert nvarchar(4000), @pathname varchar(200), @xml xml
set @pathname = 'D:\Tests\price1.xml'
create table #tmp_xml(xmldata xml)
set @insert = 'INSERT INTO #tmp_xml(xmldata) SELECT bulkcolumn 
      FROM OPENROWSET (BULK N''' + @pathname+ ''', SINGLE_BLOB) AS data'
exec sp_executesql @insert
select @xml = xmldata from #tmp_xml

INSERT INTO XML_import
SELECT 
Tbl.Col.value('goods_level[1]','int'),
Tbl.Col.value('goods_isgroup[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_code[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_name[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_parent[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_art[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_buhart[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_inpack[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_packtxt[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_country[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_gtd[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_nds[1]', 'NVARCHAR(50)'),
Tbl.Col.value('goods_unit[1]', 'NVARCHAR(50)')
FROM @xml.nodes('//goods_item') Tbl(Col)

drop table #tmp_xml

And XML:

<data_exchange>

<goods_item>
<goods_level>1</goods_level>
<goods_isgroup>1</goods_isgroup>
<goods_code>51852</goods_code>
<goods_name></goods_name>
<goods_parent></goods_parent>
<goods_art></goods_art>
<goods_buhart></goods_buhart>
<goods_inpack>0</goods_inpack>
<goods_packtxt></goods_packtxt>
<goods_country></goods_country>
<goods_gtd></goods_gtd>
<goods_nds>0</goods_nds>
<goods_unit></goods_unit>
</goods_item>

<goods_item>
<goods_level>1</goods_level>
<goods_isgroup>1</goods_isgroup>
<goods_code>51852</goods_code>
<goods_name></goods_name>
<goods_parent></goods_parent>
<goods_art></goods_art>
<goods_buhart></goods_buhart>
<goods_inpack>0</goods_inpack>
<goods_packtxt></goods_packtxt>
<goods_country></goods_country>
<goods_gtd></goods_gtd>
<goods_nds>0</goods_nds>
<goods_unit></goods_unit>
</goods_item>

<goods_item>
<goods_level>1</goods_level>
<goods_isgroup>1</goods_isgroup>
<goods_code>51852</goods_code>
<goods_name></goods_name>
<goods_parent></goods_parent>
<goods_art></goods_art>
<goods_buhart></goods_buhart>
<goods_inpack>0</goods_inpack>
<goods_packtxt></goods_packtxt>
<goods_country></goods_country>
<goods_gtd></goods_gtd>
<goods_nds>0</goods_nds>
<goods_unit></goods_unit>
</goods_item>

</data_exchange>

It’s my first project in SQL, maybe I’m dumb 🙂

Answer 1

If I were you, I’d change code to this:
Cheers

Declare @Xml    Xml

Select  @Xml    =   Convert(Xml, bulkcolumn )
    From    OpenRowSet  (
        Bulk    N'D:\Tests\price1.xml'
    ,   Single_Blob
    );

If  (
    Object_Id('XML_import') Is  Null
)   Select  Tbl.Col.value('goods_level[1]',     'Int')
    ,   Tbl.Col.value('goods_isgroup[1]',   'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_code[1]',      'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_name[1]',      'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_parent[1]',    'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_art[1]',       'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_buhart[1]',    'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_inpack[1]',    'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_packtxt[1]',   'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_country[1]',   'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_gtd[1]',       'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_nds[1]',       'NVARCHAR(50)')
    ,   Tbl.Col.value('goods_unit[1]',      'NVARCHAR(50)')
        Into    XML_import
        From    @Xml.nodes('//goods_item')  Tbl(Col)
Else    Insert  XML_import
        Select  Tbl.Col.value('goods_level[1]',     'Int')
        ,   Tbl.Col.value('goods_isgroup[1]',   'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_code[1]',      'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_name[1]',      'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_parent[1]',    'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_art[1]',       'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_buhart[1]',    'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_inpack[1]',    'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_packtxt[1]',   'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_country[1]',   'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_gtd[1]',       'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_nds[1]',       'NVARCHAR(50)')
        ,   Tbl.Col.value('goods_unit[1]',      'NVARCHAR(50)')
            From    @Xml.nodes('//goods_item')  Tbl(Col)