Question

I reviewed Netty docs, and found some comments in examples source Class: org.jboss.netty.example.factorial.FactorialServerHandler , in this src, some comments:

    //##in org.jboss.netty.example.factorial.FactorialServerPipelineFactory
    ......
    // and then business logic.
    // Please note we create a handler for every new channel
    // because it has stateful properties.
    pipeline.addLast("handler", new FactorialServerHandler());

But, I recheck other examples, such as TelnetServerPipelineFactory, seems nothing difference, the handle is create by:

    // and then business logic. 
    pipeline.addLast("handler", new TelnetServerHandler());

All the handlers are created by pipeline with “new”? And all the examples in Netty are stateful? Obviously Echo/Telnet needn’t keep stateful prop.

In my old project, I use Netty to create a Http Server to act as RESTful server, my handler code is:

    public class HttpServerPipelineFactory  implements ChannelPipelineFactory {
        private final HttpServerHandler handler;
        public ChannelPipeline getPipeline() throws Exception {
            ChannelPipeline pipeline = pipeline();
            pipeline.addLast("decoder", new HttpRequestDecoder());
            pipeline.addLast("aggregator", new HttpChunkAggregator(1048576));
            pipeline.addLast("encoder", new HttpResponseEncoder());
            pipeline.addLast("handler", handler); //singleton
            return pipeline;
        }
    }

My RESTful server is statefulless(which is one of REST meaning), so I used singleton handle. Was I right?

Answer 1

When the documentation says “stateful” it means that state informations are stored as fields in the ChannelHandler and thus its not possible to share the ChannelHandler between different Channels. If you have no state informations stored as fields you are ok to use it as Singelton.