Question

I tested the variables in the update statement and checked if a database connection is established, however the query doesn’t run, can you please show me the error in my code.

for($i=0; $i <= $numcourses; $i++){
    echo '<div class="new'.$i.'" id="new'.$i.'"><label>'.$course_names[$i].'</label>
    <input name="edit'.$i.'" type="submit" value="Edit" /><input name="delete'.$i.'" type="submit" value="Delete" /><br /></div>';
    $name="edit".$i;    
    if (isset($_POST[$name])){
        echo '<input name="text" type="text" value="'.$course_names[$i].'" /><input name="save'.$i.'" type="submit" value="Save"/>';
    }   
    $name2="save".$i;
    if (isset($_POST[$name2])){
        include "includes/open.php";
            $newname=($_POST['text']);
            $int=$i+1;
            $query = "UPDATE course SET cname = '".$newname."' WHERE cid = '".$int."'";
            mysql_query($query) or die(mysql_error());
            include "includes/close.php";
    }
}

Update: Thanx Marc B, adding or die(mysql_error());showed me the error in my code, everything works again and I’m back on track.

Answer 1

You have no error handling on your query calls:

mysql_query($query) or die(mysql_error());
                   ^^^^^^^^^^^^^^^^^^^^^^

which would tell you if there’s any problems with the query execution. On a meta level, you’re wide open to SQL injection attacks, so you’d better read up about that and fix the problem before you go any further with your code.