Question

I tried to create a list of UIimages in a UIScrollview. When I implement it horizontally it works the way I want like:

As you see the images stick together.

Then I tried it vertically. it works but an unwanted space between the images happens like:

This is my code:

@synthesize scrollView, pageControl;

// Implement viewDidLoad to do additional setup after loading the view, typically from a nib.
- (void)viewDidLoad {
    [super viewDidLoad];

    pageControlBeingUsed = NO;

    NSArray *pageImages = [NSArray arrayWithObjects:
                               [UIImage imageNamed:@"photo1.png"],
                               [UIImage imageNamed:@"photo2.png"],
                               [UIImage imageNamed:@"photo3.png"],
                               [UIImage imageNamed:@"photo4.png"],
                               [UIImage imageNamed:@"photo5.png"],
                               nil];

    for (int i = 0; i < pageImages.count; i++) {
        CGRect frame;
        //frame.origin.x = self.scrollView.frame.size.width * i;
        //frame.origin.y = 0;

        frame.origin.x = 0;
        frame.origin.y = self.scrollView.frame.size.height * i;

        frame.size = self.scrollView.frame.size;

        UIImageView *newPageView = [[UIImageView alloc] initWithImage:[pageImages objectAtIndex:i]];
        newPageView.contentMode = UIViewContentModeScaleAspectFit;
        newPageView.frame = frame;
        [self.scrollView addSubview:newPageView];
    }

    //self.scrollView.contentSize = CGSizeMake(self.scrollView.frame.size.width * pageImages.count , self.scrollView.frame.size.height);

    self.scrollView.contentSize = CGSizeMake(self.scrollView.frame.size.width , self.scrollView.frame.size.height* pageImages.count);

    self.pageControl.currentPage = 0;
    self.pageControl.numberOfPages = pageImages.count;
}

- (void)scrollViewDidScroll:(UIScrollView *)sender {
    if (!pageControlBeingUsed) {
        // Switch the indicator when more than 50% of the previous/next page is visible
        CGFloat pageWidth = self.scrollView.frame.size.height;
        int page = floor((self.scrollView.contentOffset.y - pageWidth / 2) / pageWidth) + 1;

        //CGFloat pageWidth = self.scrollView.frame.size.width;
        //int page = floor((self.scrollView.contentOffset.x - pageWidth / 2) / pageWidth) + 1;

        self.pageControl.currentPage = page;
    }
}

- (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView {
    pageControlBeingUsed = NO;
}

- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView {
    pageControlBeingUsed = NO;
}

- (IBAction)changePage {
    // Update the scroll view to the appropriate page
    CGRect frame;
    frame.origin.x = 0;
    frame.origin.y = self.scrollView.frame.size.height * self.pageControl.currentPage;

//    frame.origin.x = self.scrollView.frame.size.width * self.pageControl.currentPage;
//  frame.origin.y = 0;


    frame.size = self.scrollView.frame.size;
    [self.scrollView scrollRectToVisible:frame animated:YES];

    // Keep track of when scrolls happen in response to the page control
    // value changing. If we don't do this, a noticeable "flashing" occurs
    // as the the scroll delegate will temporarily switch back the page
    // number.
    pageControlBeingUsed = YES;
}

- (void)didReceiveMemoryWarning {
    // Releases the view if it doesn't have a superview.
    [super didReceiveMemoryWarning];

    // Release any cached data, images, etc that aren't in use.
}

- (void)viewDidUnload {
    // Release any retained subviews of the main view.
    // e.g. self.myOutlet = nil;
    self.scrollView = nil;
    self.pageControl = nil;
}

- (void)dealloc {
    [scrollView release];
    [pageControl release];
    [super dealloc];
}

@end

in the code the horizontal code lines are commented.

Can you help me to remove this unwanted space in vertical one?

Answer 1

Here the image size makes the problem.
Check with this newPageView.contentMode = UIViewContentModeScaleAspectFill; instead of newPageView.contentMode = UIViewContentModeScaleAspectFit;