Question

I want to create a dynamic 2d array by function but it seems that something is very wrong. It throws me an error when I want to put something in it.

Error

Unhandled exception at 0x003a19c8 in
p01.exe: 0xC0000005: Access violation
writing location 0xcdcdcdcd.

CreateDynamicArray()

short int** CreateDynamicArray(int row, int col)
{
    // Creating variable
    short int** dynamicArray;

    // Creating rows
    dynamicArray = (short int**)malloc(row * sizeof(short int*));

    // Going trough every row and creating columns for them
    for (int i = 0; i < row; i++)
    {
        dynamicArray[row] = (short int*)malloc(col * sizeof(short int));
    }

    // Returning created array
    return dynamicArray;
}

main()

// Creating it
dynamicArray = CreateDynamicArray(row, col);

// Filling up with random numbers
for (i = 0; i < row; i++)
{
    randomNumber = rand() % 20;
    dynamicArray[i][n] = randomNumber; // Here it throws me exception
    for (n = 0; n < col; n++)
    {
        randomNumber = rand() % 20;
        dynamicArray[i][n] = randomNumber;
    }
}

P.S.
Yes, this is somewhat of a homework, but I still need help om this matter 🙂

Answer 1

change row to i.

short int** CreateDynamicArray(int row, int col)
{
    // Creating variable
    short int** dynamicArray;

    // Creating rows
    dynamicArray = (short int**)malloc(row * sizeof(short int*));

    // Going trough every row and creating columns for them
    for (int i = 0; i < row; i++)
    {
        dynamicArray[i] = (short int*)malloc(col * sizeof(short int));
    }

    // Returning created array
    return dynamicArray;
}