Question

Is it a good practice to call a stored procedure again and again inside a foreach loop to insert data into an Oracle table? Or is there an alternate way to do this?

I have the following procedure:

procedure proc1 (id     in  varchar2,
                 level  in  varchar2,
                 title  in  varchar2, 
                 p_id   in  varchar2, 
                 url    in  varchar2)

This is the code calling it:

foreach (var c in xDoc.Descendants("cat"))
{
    // call store procedure provide all values

    foreach (var a in xDoc.Descendants("abc"))
    {
        // call store procedure provide values

        foreach (var d in xDoc.Descendants("def"))
        {
            // call stored procedure provide values
        }
     }
}

Is there a better way to do this?

Answer 1

I would personally architect the Stored Procedure to give you the table that you want so that you only have to call it once. Calling the procedure multiple times like this is horribly inefficient because the database is generating a result set multiple times and you have the network overhead. If you create the procedure to return the table that you need, instead of bits and pieces of it, you can call the procedure once and iterate through the table with the cursor.