Is the following good practice and if not what should be done?
catch(Exception e)
{
throw new Exception(e.Message, e);
}
Is the following good practice and if not what should be done? catch(Exception e)
Share
Sign Up to our social questions and Answers Engine to ask questions, answer people’s questions, and connect with other people.
Login to our social questions & Answers Engine to ask questions answer people’s questions & connect with other people.
Lost your password? Please enter your email address. You will receive a link and will create a new password via email.
Please briefly explain why you feel this question should be reported.
Please briefly explain why you feel this answer should be reported.
Please briefly explain why you feel this user should be reported.
Is the following good practice and if not what should be done?
catch(Exception e)
{
throw new Exception(e.Message, e);
}
No, this is not good practice if you’re throwing another exception of the exact same type with the same message. In doing this, you complicate the stack trace and make debugging more of a pain.
If you’re going to throw a new exception, it should differ from the original in some significant way. It should be another type, for example, or in some other way (like a more specific error message) clarify the reason for the exception. If you can’t do either of those things, then simply rethrow the current exception using
throw;.Or, even better, don’t catch it at all. Rethrowing actually messes up the stack trace a tiny bit as well (the current frame’s error location is set to the rethrow point rather than the spot where the exception happened), so if you don’t have anything you personally have to do to handle the exception, then hands off — just let it propagate and let the caller handle it.