Question

Let’s say, there are two modules is our framework: Handler.pm and Queries.pm

Queries.pm is optional and is being loaded at fastcgi process startup

BEGIN {
&{"check_module_$_"}        () foreach (Queries);

}

sub check_module_queries {
...
    require Eludia::Content::Queries;
...
}

every module function is loaded in one common namespace

now, there are two functions with same name (setup_page_content) in Handler.pm and Queries.pm

setup_page_content is being called in Handler.pm

It looks like original author suggested that Queries.pm:setup_page_content will be called, whenever Queries.pm is loaded

Sometimes it doesn’t happen: traceback (obtained via caller ()) in these cases indicates, that setup_page_content was called from module Handler.pm

I logged %INC just before call and it contains Queries.pm and it full path in these cases

This behaviour is inconsistent and pops like in 2-3% of attempts on production installation, mostly when I send two parallel identical http requests. Due amount of effort to reproduce, I doesn’t determine yet, whether it is installation specific.

How it will be decided which version of function with same name will be called?

Is it well-defined behaviour?

There should be a reason, original author wrote the code this way

UPDATE

perl version is v5.10.1 built for x86_64-linux-gnu-thread-multi

UPDATE 2

code: Handler.pm and Queries.pm

Queries.pm loading occurs in check_module_queries (BEGIN {} of Eludia.pm),

loaded for every request using Loader.pm (via use Loader.pm <params>)

Answer 1

These are not proper modules. These are simply libraries. If you turn them into proper modules with proper name spacing you won’t have this issue. You barely need to do anything more than:

package Queries;

sub new {

my $proto = shift;
my $class = ref($proto) || $proto;
my $self = {};

bless ( $self, $class );

return $self;

}

And you’ll be well on your way. Of course your program will need a couple changes to actually access the class functions. You can look at exporting to the functions to possibly save some refactoring time.

I have forked the code at github and initiated a pull request that I hope will address your problem.