Question

Method below has function to simply move files from the “working” to the “move” directory which paths it receives through the method call. It all works, but for the case when file name has name with two extensions (like .xml.md5) where the .renameTo method returns false. Is there a way to alter the below code so it would work regardless of the OS that it’s run on. (Currently it is the Windows)

public void moveToDir(String workDir, String moveDir) throws Exception {
    File tempFile = new File(workDir);
    File[] filesInWorkingDir = tempFile.listFiles();
    for (File file : filesInWorkingDir) {
        System.out.println(file.getName());
        if (new File(moveDir + File.separator + file.getName()).exists()) 
            new File(moveDir + File.separator + file.getName()).delete();
        System.out.println(moveDir + File.separator + file.getName());
        Boolean renameSuccessful = file.renameTo(new File(moveDir + File.separator + file.getName()));
        if (!renameSuccessful) throw new Exception("Can't move file to " + moveDir +": " + file.getPath());
    }
}

Answer 1

I have simplified your code and added a check if delete was successful. Try it.

public void moveToDir(String workDir, String moveDir) {
  for (File file : new File(workDir).listFiles()) {
      System.out.println(file.getName());
      final File toFile = new File(moveDir, file.getName());
      if (toFile.exists() && !toFile.delete())
        throw new RuntimeException("Cannot delete " + toFile);
      System.out.println(toFile);
      if (!file.renameTo(toFile))
        throw new RuntimeException(
          "Can't move file to " + moveDir +": " + file.getPath());
  }
}