Question

Okay, I have an achievement system and it works great except for correctly adding up the points. Here is an example of updating to the database if conditions are met:

if($members['Active']==1){    
    $Achievement1=mysql_query("SELECT * FROM ".
                                  "myachievements WHERE ".
                              "Handle='$members[Handle]' and AchievementId='1'");
    $Achievement2=mysql_num_rows($Achievement1);
    $tehdate=date('Y-m-d');
    $Points = '50';
    $newscore=$members['Points']+$Points;
    if ($Achievement2 == 0) {        
        mysql_query("INSERT INTO `myachievements` 
                         ( `Handle` , `AchievementId` , `Date` ) VALUES 
                            ('$members[Handle]', '1' , '$tehdate')"
                    )or die(mysql_error());

        mysql_query ("UPDATE members SET Achievement = 'Y' WHERE ".
                         "Handle = '$members[Handle]'")or die(mysql_error());
        mysql_query ("UPDATE members SET Points = '$newscore' WHERE ".
                         "Handle = '$members[Handle]'")or die(mysql_error());
    }

}

The achievement shown above is just for activating an account. I have about 35 achievements right now each with a different ID. So there are 35 sets of those two if statements in my main include file. My test user profile from my members table already meets the conditions for 19 of the total of 35 achievements. Everything updates in the database correctly except for adding the Points. The point total should be upwards of around 1000 points, but it always gives me 150. I’m not sure what I’m doing wrong. Any help would be appreciated.

Answer 1

I can not say specifically why it does not add the points, after moving the database stuff into functions of it’s own I would say it’s because you do not increase and store the base point value in $members['Points']:

if($members['Active']==1)
{
  $Points = '50';
  $newscore = $members['Points'] + $Points;

  if (0 == achievement_get_count($members['Handle'], 1))
  {
    achievement_add($members['Handle'], 1, date('Y-m-d'));
    achievement_set_points($members['Handle'], $newscore);
  }
}

/** achivement mysql functions */

function achievement_get_count($memberHandle, $achievementId) {
  $Achievement1=mysql_query("SELECT * FROM myachievements WHERE Handle='$memberHandle' and AchievementId='$achievementId'");
  return mysql_num_rows($Achievement1);
}

function achievement_add($memberHandle, $achievementId, $date) {
  mysql_query("INSERT INTO `myachievements` ( `Handle` , `AchievementId` , `Date` )
    VALUES (
      '$memberHandle', '$achievementId' , '$date' )")
  or die(mysql_error());
}

function achievement_set_points($memberHandle, $points) {
    mysql_query ("UPDATE members SET Achievement = 'Y', Points = '$points' WHERE Handle = '$memberHandle'")or die(mysql_error());
}