Question

Possible Duplicate:
Should a function have only one return statement?

Hello,

gcc 4.4.4 c89

Is it good programming practice to return from 1 point in a function.

I have written a function below. However, I am returning from 2 possible points.

Is this good style?

static int init_data(struct timeout_data_t *timeout_data)
{
    if(timeout_data == NULL) {
        fprintf(stderr, " [ %s ] [ %d ]\n",
            __func__, __LINE__);
        return FALSE;
    }

    /* Assign data */
    timeout_data->seconds = 3;
    timeout_data->func_ptr = timeout_cb;

    return TRUE;
}

Answer 1

I’ve had managers that lived and died by the 1 return policy for the sake of “readability”, even though it’s much more readable in some cases without it.

The bottom line is… if the man that signs your paycheck says you’re only going to use 1 return, use 1 return. The best way to do this is

type myfunc(params) {
    type result = defaultValue;
    // actual function here, word for word
    // replace "return $1" with "result = $1"

    return result;
}

This is a valid way to do things in their book, and will smile at your 1 return policy adherence. Of course, you know using this adds ZERO readability because all you’ve done is replace “return” (which is syntax highlighted) with “result =” which is not. But you’ve made your boss happy, which when you break it all down is what development is about anyway, right? 🙂