Question

Possible Duplicate:
Should a function have only one return statement?

This is what I am talking about.

if (condition) {
    aVariable = 1;
    return;
}
doSomething();

if (condition) {
    aVariable = 1;
} else {
    doSomething();
}

Is one of these preferred over the other (conventions, etc)?

Answer 1

Readability is most important.
So early returns on begining of functions are ok, but once method starts doing something more complicated than checking its imputs/state of object, it should have only one return .

And if it is too complicated, it should be refactored to multiple functions.