Question

This doesn’t compile and gives the following error: Illegal start of expression. Why?

public static AppConfig getInstance() {
    return mConfig != null ? mConfig : (throw new RuntimeException("error"));
}

Answer 1

This is because a ternary operator in java takes the form expression ? expression : expression, and you are giving a statement as the final part. This doesn’t make sense as a statement doesn’t give a value, while expressions do. What is Java meant to do when it finds the condition to be false and tries to give the second value? There is no value.

The ternary operator is designed to allow you to quickly make a choice between two variables without using a full if statement – that isn’t what you are trying to do, so don’t use it, the best solution is simply:

public static AppConfig getInstance() {
    if (mConfig != null) {
        return mConfig;
    } else {
        throw new RuntimeException("error");
    }
}

The ternary operator isn’t designed to produce side effects – while it can be made to produce them, people reading it won’t expect that, so it’s far better to use a real if statement to make it clear.