Question

This loop is strange.

I ran this in Java, it gives an Index out of bounds exception. I can’t find an int l declaration anywhere in the source code and i can’t figure out what it is and found out that it is legal for it to be declared this way.

But the deal here is, i don’t understand what this piece of code is doing. For any size of resultSIList, it gives an ArrayIndexOutOfBoundsException.

for (int i = offset, l = Math.min(i + maxItemsInOnePage, totalSIs); i < l; i++){
    resultSIList.get(i);
}

EDIT: Thanks all.

Here is a runnable code i am using to try to understand this entire loop. Yes it is a horrible piece of junk.

public class IndexOutOfBoundsTest {
    public static void main(String args[]){
        int offset = 50;

        int maxItemsInOnePage = 50;

        int totalSIs = 50;

        final int buildThis = 15;

        List resultSIList = new ArrayList();

        // build list
        for(int zz = 0; zz < buildThis; zz ++){
            resultSIList.add("Hi " + zz);
        }

        try{
            for (int i = offset,
                    d = Math.min(i + maxItemsInOnePage, totalSIs);
                    i < d; i++){

               System.out.println(resultSIList.get(i));
           }
        }catch(Exception e){
            e.printStackTrace();
        }
    }
}

Answer 1

It works as expected if and only if totalSIs is equal to or less then the size of the resultSIList. Double check that value. Here’s a working example with some random values:

List<Integer> resultSIList = Arrays.asList(1,2,3,4,5,6,7,8);
int totalSIs = resultSIList.size();
int maxItemsInOnePage = 2;
int offset = 1;

for (int i = offset, l = Math.min(i + maxItemsInOnePage, totalSIs); i < l; i++){
  resultSIList.get(i);
}

---

From you added code I see, that totalSIs is bigger (=50) then the list size (=15).

You could add

 totalSIs = resultsSIList.size();

right behind the for loop for a quick fix.