Question

What would be the best way of writing the below if statement more efficiently?

        if (!preg_match('/^[0-9]+$/', $min) || 
            !preg_match('/^[0-9]+$/', $max) ||
            !preg_match('/^[0-9]+$/', $c1) ||
            !preg_match('/^[0-9]+$/', $c2) ||
            !preg_match('/^[0-9]+$/', $c3) ||
            !preg_match('/^[0-9]+$/', $c4) ||
            !preg_match('/^[0-9]+$/', $c5) ||
        )
        {
          echo 'Wrong value"
          exit;
        };

Thanks in advance!

Btw I am validating for integers…. whole numbers!

Answer 1

How about:

$tests = array($min, $max, $c1, $c2, $c3, $c4, $c5);

if (count(preg_grep('/^\d+$/', $tests, PREG_GREP_INVERT)) > 0) {
  echo 'Wrong value';
  exit;
}

• preg_grep() docs
• Note that I have changed the regex to use the \d sequence instead of a character class.