Question

When you need to do something like this:

SELECT * FROM userinfo WHERE id in (18,2,6,4,5)

And the id array comes from another query like:

$ids = $conn->fetchAll('SELECT origin from action WHERE url = "'.$url.'" AND SUBSTRING(origin,1,3)<>"pct" GROUP BY origin');

If I need to parse the array in order to give the right format to the query id do:

    $norm_ids = '(';
    foreach ($ids as $ids) {
        $norm_ids .= $ids['origin'] .',';
    }
    $norm_ids = substr_replace($norm_ids ,"",-1) .')';

That outputs the ids like: (id1,id2,id3,id.......), so the I’ll just: FROM userinfo WHERE id in ". $norm_ids;

But seems to ugly to me, is there a way to do this better?

Answer 1

You could do:

$idStr = rtrim(str_repeat('?,', count($ids), ',');
$query = 'SELECT * FROM userinfo WHERE id in (' . $idStr . ')';

and then use prepare():

$conn = $db->prepare($query);
$conn->execute($ids);
$res = $conn->fetchAll(...);