Question

I have a code like this:

<?php

$kode ["J"]= array (20, C, D, F);
$kode ["K"]= array (50, B, G, U);
$kode ["T"]= array (70, V, W);

function kota ($start, $end){
    if (is_array($kode)) {
        foreach ($kode as $kota => $path){
            if ($kota=$end) {
                for ($i=1; $i < count ($kota); $i++){
                    $jalur=$start.$path[$i];
                }
            }
        }
        return $jalur;
    }
}
$start = "J";
$end = "T";
$hasil=kota ($start, $end);
echo "".$hasil;
?>

I want the output to be J-V-W
I don’t know what is wrong, can anyone help me? please…

Answer 1

Your code has lots of issues

1. As others pointed out, in if ($kota=$end) {, you are assigning $end to $kota and always return true i.e. the code in the IF clause always execute

2. PHP has function scope. Simply put, variables declared inside a function cannot be used outside, and vice versa. Use parameters to pass your $kode into the function.

3. Use of bare strings i.e. V and W in $kode ["T"]= array (70, V, W); and other places. This is highly recommended against, and PHP does warn you about this.

4. As other pointed out, $jalur=$start.$path[$i]; would overwrite $jalur every time. The for-loop outside is meaningless. You would use .= the append-to operator. Note that you also need to initialize your variable before using this operator.

5. $kota is always a string in your code, because in a foreach loop, the variable before => symbol means get the key of the array, and array keys can only be either String or integer. That said, for ($i=1; $i < count ($kota); $i++){ is meaningless because count($kota) cannot be greater than 1 – your for loop actually never runs.

6. This is blatantly meaningless to append a variable with an empty string as in echo "".$hasil;

I guess this is what you want.

<?php

$kode ["J"] = array (20, 'C', 'D', 'F');
$kode ["K"] = array (50, 'B', 'G', 'U');
$kode ["T"] = array (70, 'V', 'W');

function kota ($kode, $start, $end){
    $jalur = $start;
    if (is_array($kode)) {
        foreach ($kode as $kota => $path){
            if ($kota == $end) {
                for ($i = 1; $i < count($path); ++$i) {
                    $jalur .= '-' . $path[$i];
                }
            }
        }
        return $jalur;
    }
}
$start = "J";
$end = "T";
$hasil = kota($kode, $start, $end);
echo $hasil;
?>

This code give you the string which starts with $start and all other elements except the first element in $kode[$end]